sp
/
tempest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

avoid temporary in Eigen solver by providing .noalias(). slightly rewrote matrix-vector expression to benefit more from Eigen's optimization capabilities 

Former-commit-id: 838eac1449
main
dehnert 9 years ago
parent
69da4ff147
commit
d24fb0cf9a
1 changed files with 12 additions and 11 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 23
      src/solver/EigenLinearEquationSolver.cpp

23
src/solver/EigenLinearEquationSolver.cpp
View File

@ -147,9 +147,10 @@ namespace storm {
auto currentX = &eigenX; auto currentX = &eigenX;
auto nextX = &eigenMultiplyResult; auto nextX = &eigenMultiplyResult;
for (uint64_t iteration = 0; iteration < n; ++iteration) { for (uint64_t iteration = 0; iteration < n; ++iteration) {
*nextX = *eigenA * *currentX;
if (eigenB != nullptr) {
*nextX += *eigenB;
if (eigenB) {
nextX->noalias() = *eigenA * *currentX + *eigenB;
} else {
nextX->noalias() = *eigenA * *currentX;
} }
std::swap(nextX, currentX); std::swap(nextX, currentX);
} }
@ -209,11 +210,11 @@ namespace storm {
auto currentX = &eigenX; auto currentX = &eigenX;
auto nextX = &eigenMultiplyResult; auto nextX = &eigenMultiplyResult;
for (uint64_t iteration = 0; iteration < n; ++iteration) { for (uint64_t iteration = 0; iteration < n; ++iteration) {
*nextX = *eigenA * *currentX;
if (eigenB != nullptr) {
*nextX += *eigenB;
if (eigenB) {
nextX->noalias() = *eigenA * *currentX + *eigenB;
} else {
nextX->noalias() = *eigenA * *currentX;
} }
std::swap(currentX, nextX);
} }
// If the last result we obtained is not the one in the input vector x, we swap the result there. // If the last result we obtained is not the one in the input vector x, we swap the result there.
@ -261,11 +262,11 @@ namespace storm {
auto currentX = &eigenX; auto currentX = &eigenX;
auto nextX = &eigenMultiplyResult; auto nextX = &eigenMultiplyResult;
for (uint64_t iteration = 0; iteration < n; ++iteration) { for (uint64_t iteration = 0; iteration < n; ++iteration) {
*nextX = *eigenA * *currentX;
if (eigenB != nullptr) {
*nextX += *eigenB;
if (eigenB) {
nextX->noalias() = *eigenA * *currentX + *eigenB;
} else {
nextX->noalias() = *eigenA * *currentX;
} }
std::swap(nextX, currentX);
} }
// If the last result we obtained is not the one in the input vector x, we swap the result there. // If the last result we obtained is not the one in the input vector x, we swap the result there.

Write Preview
Loading…
Cancel
Save