graph preservation properties correctly computed for CTMCs

src/storm-pars-cli/storm-pars.cpp

@@ -375,6 +375,11 @@ namespace storm {
                                                     boost::optional<ValueType> rationalFunction = result->asExplicitQuantitativeCheckResult<ValueType>()[*model->getInitialStates().begin()];
                                                     storm::api::exportParametricResultToFile(rationalFunction, storm::analysis::ConstraintCollector<ValueType>(*dtmc), parametricSettings.exportResultPath());
                                                 }
+                                                else if (parametricSettings.exportResultToFile() && model->isOfType(storm::models::ModelType::Ctmc)) {
+                                                    auto ctmc = model->template as<storm::models::sparse::Ctmc<ValueType>>();
+                                                    boost::optional<ValueType> rationalFunction = result->asExplicitQuantitativeCheckResult<ValueType>()[*model->getInitialStates().begin()];
+                                                    storm::api::exportParametricResultToFile(rationalFunction, storm::analysis::ConstraintCollector<ValueType>(*ctmc), parametricSettings.exportResultPath());
+                                                }
                                             });
             } else {
                 STORM_LOG_TRACE("Sampling the model at given points.");

src/storm/analysis/GraphConditions.cpp

@@ -56,6 +56,9 @@ namespace storm {
 
         template <typename ValueType>
         void ConstraintCollector<ValueType>::process(storm::models::sparse::Model<ValueType> const& model) {
+
+            if (model.getType() != storm::models::ModelType::Ctmc) {
+
                 for(uint_fast64_t action = 0; action < model.getTransitionMatrix().getRowCount(); ++action) {
                     ValueType sum = storm::utility::zero<ValueType>();
 
@@ -98,6 +101,26 @@ namespace storm {
                         wellformedConstraintSet.emplace((sum.nominator() - sum.denominator()).polynomialWithCoefficient(), storm::CompareRelation::EQ);
                     }
                 }
+            } else {
+                for (auto const& transition : model.getTransitionMatrix()) {
+                    if(!transition.getValue().isConstant()) {
+                        if (transition.getValue().denominator().isConstant()) {
+                            assert(transition.getValue().denominator().constantPart() != 0);
+                            if (transition.getValue().denominator().constantPart() > 0) {
+                                wellformedConstraintSet.emplace(transition.getValue().nominator().polynomialWithCoefficient(), storm::CompareRelation::GEQ);
+                            } else if (transition.getValue().denominator().constantPart() < 0) {
+                                wellformedConstraintSet.emplace(transition.getValue().nominator().polynomialWithCoefficient(), storm::CompareRelation::LEQ);
+                            } else {
+                                assert(false); // Should fail before.
+                            }
+                        } else {
+                            wellformedConstraintSet.emplace(transition.getValue().denominator().polynomialWithCoefficient(), storm::CompareRelation::NEQ);
+                            wellformedConstraintSet.emplace(carl::FormulaType::ITE, typename ConstraintType<ValueType>::val(transition.getValue().denominator().polynomialWithCoefficient(), storm::CompareRelation::GREATER), typename ConstraintType<ValueType>::val(transition.getValue().nominator().polynomialWithCoefficient(), storm::CompareRelation::GEQ), typename ConstraintType<ValueType>::val(transition.getValue().nominator().polynomialWithCoefficient(), storm::CompareRelation::LEQ));
+                        }
+                        graphPreservingConstraintSet.emplace(transition.getValue().nominator().polynomialWithCoefficient(), storm::CompareRelation::NEQ);
+                    }
+                }
+            }
 
             if (model.getType() == storm::models::ModelType::Ctmc) {
                 auto const& exitRateVector = static_cast<storm::models::sparse::Ctmc<ValueType> const&>(model).getExitRateVector();