sp
/
tempest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

DeterministicSchedsLpChecker: Bug fixes, further experiments with upper reward bounds

tempestpy_adaptions
Tim Quatmann 5 years ago
parent
06c0aff14c
commit
f1536369be
4 changed files with 252 additions and 80 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 94
      src/storm/modelchecker/multiobjective/deterministicScheds/DeterministicSchedsLpChecker.cpp
  2. 131
      src/storm/modelchecker/multiobjective/deterministicScheds/DeterministicSchedsObjectiveHelper.cpp
  3. 4
      src/storm/solver/GurobiLpSolver.cpp
  4. 17
      src/storm/storage/geometry/PolytopeTree.h

94
src/storm/modelchecker/multiobjective/deterministicScheds/DeterministicSchedsLpChecker.cpp
View File

@ -136,7 +136,7 @@ namespace storm {
template <typename ModelType, typename GeometryValueType> template <typename ModelType, typename GeometryValueType>
std::pair<std::vector<std::vector<GeometryValueType>>, std::vector<std::shared_ptr<storm::storage::geometry::Polytope<GeometryValueType>>>> DeterministicSchedsLpChecker<ModelType, GeometryValueType>::check(storm::Environment const& env, storm::storage::geometry::PolytopeTree<GeometryValueType>& polytopeTree, GeometryValueType const& eps) { std::pair<std::vector<std::vector<GeometryValueType>>, std::vector<std::shared_ptr<storm::storage::geometry::Polytope<GeometryValueType>>>> DeterministicSchedsLpChecker<ModelType, GeometryValueType>::check(storm::Environment const& env, storm::storage::geometry::PolytopeTree<GeometryValueType>& polytopeTree, GeometryValueType const& eps) {
std::cout << "Checking " << polytopeTree.toString() << std::endl << "\t";
STORM_LOG_INFO("Checking " << polytopeTree.toString());
swCheck.start(); swCheck.start();
STORM_LOG_ASSERT(!currentWeightVector.empty(), "Checking invoked before specifying a weight vector."); STORM_LOG_ASSERT(!currentWeightVector.empty(), "Checking invoked before specifying a weight vector.");
if (polytopeTree.isEmpty()) { if (polytopeTree.isEmpty()) {
@ -159,7 +159,6 @@ namespace storm {
checkRecursive(env, polytopeTree, eps, foundPoints, infeasableAreas, 0); checkRecursive(env, polytopeTree, eps, foundPoints, infeasableAreas, 0);
swCheck.stop(); swCheck.stop();
std::cout << " done!" << std::endl;
return {foundPoints, infeasableAreas}; return {foundPoints, infeasableAreas};
} }
@ -210,28 +209,39 @@ namespace storm {
// Compute an upper bound on the expected number of visits of the states in this ec. // Compute an upper bound on the expected number of visits of the states in this ec.
// First get a lower bound l on the probability of a path that leaves this MEC. 1-l is an upper bound on Pr_s(X F s). // First get a lower bound l on the probability of a path that leaves this MEC. 1-l is an upper bound on Pr_s(X F s).
// The desired upper bound is thus 1/(1-(1-l)) = 1/l. See Baier et al., CAV'17 // The desired upper bound is thus 1/(1-(1-l)) = 1/l. See Baier et al., CAV'17
ValueType expVisitsUpperBound;
uint64_t numStates = std::distance(ec.begin(), ec.end());
{
std::vector<ValueType> leastPathProbs(transitions.getRowGroupCount(), storm::utility::one<ValueType>());
std::vector<ValueType> prevLeastPathProbs(transitions.getRowGroupCount(), storm::utility::one<ValueType>());
for (uint64_t i = 0; i < numStates; ++i) {
// To compute l, we multiply the smallest transition probabilities occurring at each state and MEC-Choice
// as well as the smallest 'exit' probability
ValueType lpath = storm::utility::one<ValueType>();
ValueType minExitProbability = storm::utility::one<ValueType>();
for (auto const& stateChoices : ec) { for (auto const& stateChoices : ec) {
auto state = stateChoices.first; auto state = stateChoices.first;
auto currVal = prevLeastPathProbs[state];
for (auto const& transition : transitions.getRowGroup(state)) {
ValueType minProb = storm::utility::one<ValueType>();
for (uint64_t choice = transitions.getRowGroupIndices()[state]; choice < transitions.getRowGroupIndices()[state + 1]; ++state) {
if (stateChoices.second.count(choice) == 0) {
// The choice leaves the EC, so we take the sum over the exiting probabilities
ValueType exitProbabilitySum = storm::utility::zero<ValueType>();
for (auto const& transition : transitions.getRow(choice)) {
if (!ec.containsState(transition.getColumn())) {
exitProbabilitySum += transition.getValue();
}
}
minExitProbability = std::min(minExitProbability, exitProbabilitySum);
} else {
// Get the minimum over all transition probabilities
for (auto const& transition : transitions.getRow(choice)) {
if (!storm::utility::isZero(transition.getValue())) { if (!storm::utility::isZero(transition.getValue())) {
currVal = std::min<ValueType>(currVal, transition.getValue() * prevLeastPathProbs[transition.getColumn()]);
minProb = std::min(minProb, transition.getValue());
} }
} }
leastPathProbs[state] = currVal;
} }
leastPathProbs.swap(prevLeastPathProbs);
} }
ValueType l = *std::min_element(leastPathProbs.begin(), leastPathProbs.end());
expVisitsUpperBound = storm::utility::one<ValueType>() / l;
lpath *= minProb;
} }
expVisitsUpperBound = storm::utility::one<ValueType>() / expVisitsUpperBound;
lpath *= minExitProbability;
ValueType expVisitsUpperBound = storm::utility::one<ValueType>() / lpath;
STORM_LOG_WARN_COND(expVisitsUpperBound <= storm::utility::convertNumber<ValueType>(1000.0), "Large upper bound for expected visiting times: " << expVisitsUpperBound);
// create variables // create variables
for (auto const& stateChoices : ec) { for (auto const& stateChoices : ec) {
ecStateVars.emplace(stateChoices.first, lpModel.addBoundedIntegerVariable("e" + std::to_string(stateChoices.first) + varNameSuffix, storm::utility::zero<ValueType>(), storm::utility::one<ValueType>()).getExpression()); ecStateVars.emplace(stateChoices.first, lpModel.addBoundedIntegerVariable("e" + std::to_string(stateChoices.first) + varNameSuffix, storm::utility::zero<ValueType>(), storm::utility::one<ValueType>()).getExpression());
@ -271,6 +281,7 @@ namespace storm {
} }
outs.emplace(stateChoices.first, out); outs.emplace(stateChoices.first, out);
} }
uint64_t numStates = std::distance(ec.begin(), ec.end());
for (auto const& stateChoices : ec) { for (auto const& stateChoices : ec) {
auto in = ins.find(stateChoices.first); auto in = ins.find(stateChoices.first);
STORM_LOG_ASSERT(in != ins.end(), "ec state does not seem to have an incoming transition."); STORM_LOG_ASSERT(in != ins.end(), "ec state does not seem to have an incoming transition.");
@ -301,18 +312,24 @@ namespace storm {
storm::storage::MaximalEndComponentDecomposition<ValueType> mecs(model.getTransitionMatrix(), backwardTransitions, storm::storage::BitVector(model.getNumberOfStates(), true), choicesWithValueZero); storm::storage::MaximalEndComponentDecomposition<ValueType> mecs(model.getTransitionMatrix(), backwardTransitions, storm::storage::BitVector(model.getNumberOfStates(), true), choicesWithValueZero);
for (auto const& mec : mecs) { for (auto const& mec : mecs) {
// For each objective we might need to split this mec into several subECs, if the objective yields a non-zero scheduler-independent state value for some states of this ec.
std::map<std::set<uint64_t>, std::vector<uint64_t>> excludedStatesToObjIndex; std::map<std::set<uint64_t>, std::vector<uint64_t>> excludedStatesToObjIndex;
bool mecContainsSchedulerDependentValue = false;
for (uint64_t objIndex = 0; objIndex < objectiveHelper.size(); ++objIndex) { for (uint64_t objIndex = 0; objIndex < objectiveHelper.size(); ++objIndex) {
std::set<uint64_t> excludedStates; std::set<uint64_t> excludedStates;
for (auto const& stateChoices : mec) { for (auto const& stateChoices : mec) {
auto schedIndValueIt = objectiveHelper[objIndex].getSchedulerIndependentStateValues().find(stateChoices.first); auto schedIndValueIt = objectiveHelper[objIndex].getSchedulerIndependentStateValues().find(stateChoices.first);
if (schedIndValueIt != objectiveHelper[objIndex].getSchedulerIndependentStateValues().end() && !storm::utility::isZero(schedIndValueIt->second)) {
if (schedIndValueIt == objectiveHelper[objIndex].getSchedulerIndependentStateValues().end()) {
mecContainsSchedulerDependentValue = true;
} else if (!storm::utility::isZero(schedIndValueIt->second)) {
excludedStates.insert(stateChoices.first); excludedStates.insert(stateChoices.first);
} }
} }
excludedStatesToObjIndex[excludedStates].push_back(objIndex); excludedStatesToObjIndex[excludedStates].push_back(objIndex);
} }
// Skip this mec if all state values are independent of the scheduler (e.g. no reward is reachable from here).
if (mecContainsSchedulerDependentValue) {
for (auto const& exclStates : excludedStatesToObjIndex) { for (auto const& exclStates : excludedStatesToObjIndex) {
if (exclStates.first.empty()) { if (exclStates.first.empty()) {
auto ecVars = processEc(mec, model.getTransitionMatrix(), "", choiceVariables, *lpModel); auto ecVars = processEc(mec, model.getTransitionMatrix(), "", choiceVariables, *lpModel);
@ -346,7 +363,8 @@ namespace storm {
} }
} }
} }
std::cout << "found " << ecCounter << "many ECs" << std::endl;
}
STORM_LOG_WARN_COND(ecCounter == 0, "Processed " << ecCounter << " End components.");
return result; return result;
} }
@ -437,7 +455,8 @@ namespace storm {
std::vector<storm::expressions::Expression> ecValVars(model.getNumberOfStates()); std::vector<storm::expressions::Expression> ecValVars(model.getNumberOfStates());
if (hasEndComponents) { if (hasEndComponents) {
for (auto const& state : nonBottomStates) { for (auto const& state : nonBottomStates) {
// For the in-out-encoding, all objectives have the same ECs. Hence, we only care for the variables of the first objective.
// For the in-out-encoding, all objectives have the same ECs (because there are no non-zero scheduler independend state values).
// Hence, we only care for the variables of the first objective.
if (ecVars.front()[state].isInitialized()) { if (ecVars.front()[state].isInitialized()) {
ecValVars[state] = lpModel->addBoundedContinuousVariable("z" + std::to_string(state), storm::utility::zero<ValueType>(), visitingTimesUpperBounds[state]).getExpression(); ecValVars[state] = lpModel->addBoundedContinuousVariable("z" + std::to_string(state), storm::utility::zero<ValueType>(), visitingTimesUpperBounds[state]).getExpression();
lpModel->addConstraint("", ecValVars[state] <= lpModel->getConstant(visitingTimesUpperBounds[state]) * ecVars.front()[state]); lpModel->addConstraint("", ecValVars[state] <= lpModel->getConstant(visitingTimesUpperBounds[state]) * ecVars.front()[state]);
@ -490,10 +509,13 @@ namespace storm {
} }
} }
auto objValueVariable = lpModel->addBoundedContinuousVariable("x" + std::to_string(objIndex), objectiveHelper[objIndex].getLowerValueBoundAtState(env, initialState), objectiveHelper[objIndex].getUpperValueBoundAtState(env, initialState)); auto objValueVariable = lpModel->addBoundedContinuousVariable("x" + std::to_string(objIndex), objectiveHelper[objIndex].getLowerValueBoundAtState(env, initialState), objectiveHelper[objIndex].getUpperValueBoundAtState(env, initialState));
if (objValue.empty()) {
lpModel->addConstraint("", objValueVariable == zero);
} else {
lpModel->addConstraint("", objValueVariable == storm::expressions::sum(objValue)); lpModel->addConstraint("", objValueVariable == storm::expressions::sum(objValue));
}
initialStateResults.push_back(objValueVariable); initialStateResults.push_back(objValueVariable);
} }
} else { } else {
// 'classic' backward encoding. // 'classic' backward encoding.
for (uint64_t objIndex = 0; objIndex < objectiveHelper.size(); ++objIndex) { for (uint64_t objIndex = 0; objIndex < objectiveHelper.size(); ++objIndex) {
@ -622,7 +644,7 @@ namespace storm {
} }
template <typename ModelType, typename GeometryValueType> template <typename ModelType, typename GeometryValueType>
void DeterministicSchedsLpChecker<ModelType, GeometryValueType>::checkRecursive(Environment const& env, storm::storage::geometry::PolytopeTree <GeometryValueType>& polytopeTree, GeometryValueType const& eps, std::vector<Point>& foundPoints, std::vector<Polytope>& infeasableAreas, uint64_t const& depth) {
void DeterministicSchedsLpChecker<ModelType, GeometryValueType>::checkRecursive(Environment const& env, storm::storage::geometry::PolytopeTree<GeometryValueType>& polytopeTree, GeometryValueType const& eps, std::vector<Point>& foundPoints, std::vector<Polytope>& infeasableAreas, uint64_t const& depth) {
std::cout << "."; std::cout << ".";
std::cout.flush(); std::cout.flush();
STORM_LOG_ASSERT(!polytopeTree.isEmpty(), "Tree node is empty"); STORM_LOG_ASSERT(!polytopeTree.isEmpty(), "Tree node is empty");
@ -647,15 +669,18 @@ namespace storm {
STORM_LOG_TRACE("\tDone solving MILP..."); STORM_LOG_TRACE("\tDone solving MILP...");
swLpSolve.stop(); swLpSolve.stop();
//std::cout << "writing model to file out.lp"<< std::endl;
//lpModel->writeModelToFile("out.lp");
#ifndef NDEBUG
STORM_PRINT_AND_LOG("Writing model to file '" << polytopeTree.toId() << ".lp'" << std::endl;);
lpModel->writeModelToFile(polytopeTree.toId() + ".lp");
#endif
if (lpModel->isInfeasible()) { if (lpModel->isInfeasible()) {
infeasableAreas.push_back(polytopeTree.getPolytope()); infeasableAreas.push_back(polytopeTree.getPolytope());
polytopeTree.clear(); polytopeTree.clear();
} else { } else {
STORM_LOG_ASSERT(!lpModel->isUnbounded(), "LP result is unbounded."); STORM_LOG_ASSERT(!lpModel->isUnbounded(), "LP result is unbounded.");
// TODO: only for debugging
#ifndef NDEBUG
validateCurrentModel(env); validateCurrentModel(env);
#endif
Point newPoint; Point newPoint;
for (auto const& objVar : currentObjectiveVariables) { for (auto const& objVar : currentObjectiveVariables) {
newPoint.push_back(storm::utility::convertNumber<GeometryValueType>(lpModel->getContinuousValue(objVar))); newPoint.push_back(storm::utility::convertNumber<GeometryValueType>(lpModel->getContinuousValue(objVar)));
@ -688,20 +713,21 @@ namespace storm {
if (infeasableAreas.back()->isEmpty()) { if (infeasableAreas.back()->isEmpty()) {
infeasableAreas.pop_back(); infeasableAreas.pop_back();
} }
swAux.start();
polytopeTree.setMinus(storm::storage::geometry::Polytope<GeometryValueType>::create({halfspace})); polytopeTree.setMinus(storm::storage::geometry::Polytope<GeometryValueType>::create({halfspace}));
for (auto const& p : newPoints) { for (auto const& p : newPoints) {
foundPoints.push_back(p); foundPoints.push_back(p);
polytopeTree.substractDownwardClosure(p, eps); polytopeTree.substractDownwardClosure(p, eps);
} }
swAux.stop();
if (!polytopeTree.isEmpty()) { if (!polytopeTree.isEmpty()) {
checkRecursive(env, polytopeTree, eps, foundPoints, infeasableAreas, depth); checkRecursive(env, polytopeTree, eps, foundPoints, infeasableAreas, depth);
} }
} }
} else { } else {
// Traverse all the children.
// Traverse all the non-empty children.
for (uint64_t childId = 0; childId < polytopeTree.getChildren().size(); ++childId) { for (uint64_t childId = 0; childId < polytopeTree.getChildren().size(); ++childId) {
if (polytopeTree.getChildren()[childId].isEmpty()) {
continue;
}
uint64_t newPointIndex = foundPoints.size(); uint64_t newPointIndex = foundPoints.size();
checkRecursive(env, polytopeTree.getChildren()[childId], eps, foundPoints, infeasableAreas, depth + 1); checkRecursive(env, polytopeTree.getChildren()[childId], eps, foundPoints, infeasableAreas, depth + 1);
STORM_LOG_ASSERT(polytopeTree.getChildren()[childId].isEmpty(), "expected empty children."); STORM_LOG_ASSERT(polytopeTree.getChildren()[childId].isEmpty(), "expected empty children.");
@ -734,7 +760,13 @@ namespace storm {
uint64_t globalChoiceOffset = model.getTransitionMatrix().getRowGroupIndices()[state]; uint64_t globalChoiceOffset = model.getTransitionMatrix().getRowGroupIndices()[state];
bool choiceFound = false; bool choiceFound = false;
for (uint64_t localChoice = 0; localChoice < numChoices; ++localChoice) { for (uint64_t localChoice = 0; localChoice < numChoices; ++localChoice) {
if (lpModel->getIntegerValue(choiceVariables[globalChoiceOffset + localChoice].getBaseExpression().asVariableExpression().getVariable()) == 1) {
bool localChoiceEnabled = false;
if (choiceVarReduction() && localChoice + 1 == numChoices) {
localChoiceEnabled = !choiceFound;
} else {
localChoiceEnabled = (lpModel->getIntegerValue(choiceVariables[globalChoiceOffset + localChoice].getBaseExpression().asVariableExpression().getVariable()) == 1);
}
if (localChoiceEnabled) {
STORM_LOG_THROW(!choiceFound, storm::exceptions::UnexpectedException, "Multiple choices selected at state " << state); STORM_LOG_THROW(!choiceFound, storm::exceptions::UnexpectedException, "Multiple choices selected at state " << state);
scheduler.setChoice(localChoice, state); scheduler.setChoice(localChoice, state);
choiceFound = true; choiceFound = true;
@ -750,9 +782,9 @@ namespace storm {
expectedValue = -expectedValue; expectedValue = -expectedValue;
} }
ValueType actualValue = objectiveHelper[objIndex].evaluateOnModel(env, *inducedModel); ValueType actualValue = objectiveHelper[objIndex].evaluateOnModel(env, *inducedModel);
std::cout << "obj" << objIndex << ": LpSolver: " << storm::utility::convertNumber<double>(expectedValue) << " (" << expectedValue << ")" << std::endl;
std::cout << "obj" << objIndex << ": model checker: " << storm::utility::convertNumber<double>(actualValue) << " (" << actualValue << ")" << std::endl;
STORM_LOG_THROW(storm::utility::convertNumber<double>(storm::utility::abs<ValueType>(actualValue - expectedValue)) <= 1e-4, storm::exceptions::UnexpectedException, "Invalid value for objective " << objIndex << ": expected " << expectedValue << " but got " << actualValue);
double diff = storm::utility::convertNumber<double>(storm::utility::abs<ValueType>(expectedValue - actualValue));
STORM_PRINT_AND_LOG("Validating Lp solution for objective " << objIndex << ": LP" << storm::utility::convertNumber<double>(expectedValue) << " InducedScheduler=" << storm::utility::convertNumber<double>(actualValue) << " (difference is " << diff << ")" << std::endl);
STORM_LOG_WARN_COND(diff <= 1e-4 * std::abs(storm::utility::convertNumber<double>(actualValue)), "Invalid value for objective " << objIndex << ": expected " << expectedValue << " but got " << actualValue << " (difference is " << diff << ")");
} }
std::cout << std::endl; std::cout << std::endl;

131
src/storm/modelchecker/multiobjective/deterministicScheds/DeterministicSchedsObjectiveHelper.cpp
View File

@ -18,6 +18,12 @@
#include "storm/logic/CloneVisitor.h" #include "storm/logic/CloneVisitor.h"
#include "storm/environment/solver/MinMaxSolverEnvironment.h" #include "storm/environment/solver/MinMaxSolverEnvironment.h"
#include "storm/transformer/EndComponentEliminator.h" #include "storm/transformer/EndComponentEliminator.h"
#include "storm/utility/solver.h"
#include "storm/solver/LpSolver.h"
#include "storm/solver/GurobiLpSolver.h"
#include "storm/solver/SmtSolver.h"
#include "storm/storage/expressions/Expressions.h"
#include "storm/exceptions/UnexpectedException.h" #include "storm/exceptions/UnexpectedException.h"
namespace storm { namespace storm {
@ -260,6 +266,7 @@ namespace storm {
return objective.formula->isRewardOperatorFormula() && objective.formula->getSubformula().isTotalRewardFormula(); return objective.formula->isRewardOperatorFormula() && objective.formula->getSubformula().isTotalRewardFormula();
} }
/*
template <typename ValueType> template <typename ValueType>
ValueType getLpathDfs(uint64_t currentState, ValueType currentValue, storm::storage::BitVector& visited, storm::storage::BitVector const& mecStates, storm::storage::SparseMatrix<ValueType> const& transitions, uint64_t& counter) { ValueType getLpathDfs(uint64_t currentState, ValueType currentValue, storm::storage::BitVector& visited, storm::storage::BitVector const& mecStates, storm::storage::SparseMatrix<ValueType> const& transitions, uint64_t& counter) {
// exhausive dfs // exhausive dfs
@ -279,6 +286,82 @@ namespace storm {
} }
} }
void oneOfManyEncoding(std::vector<storm::expressions::Expression>& operands, storm::solver::SmtSolver& solver) {
assert(!operands.empty());
uint64_t currentOperand = 0;
while (currentOperand + 2 < operands.size()) {
solver.add(!(operands[currentOperand] && operands[currentOperand + 1]));
auto auxVar = solver.getManager().declareFreshBooleanVariable(true).getExpression();
solver.add(storm::expressions::iff(auxVar, (operands[currentOperand] || operands[currentOperand + 1])));
operands.push_back(auxVar);
currentOperand += 2;
}
if (currentOperand + 1 == operands.size()) {
solver.add(operands[currentOperand]);
} else if (currentOperand + 2 == operands.size()) {
solver.add(storm::expressions::xclusiveor(operands[currentOperand], operands[currentOperand + 1]));
}
}
*/
/*
template <typename ValueType>
ValueType getExpVisitsUpperBoundForMec(storm::storage::BitVector const& mecStates, storm::storage::SparseMatrix<ValueType> const& transitions) {
auto generalSolver = storm::utility::solver::getLpSolver<ValueType>("mecBounds", storm::solver::LpSolverTypeSelection::Gurobi);
auto solver = dynamic_cast<storm::solver::GurobiLpSolver<ValueType>*>(generalSolver.get());
solver->setOptimizationDirection(storm::solver::OptimizationDirection::Maximize);
auto one = solver->getConstant(storm::utility::one<ValueType>());
auto zero = solver->getConstant(storm::utility::zero<ValueType>());
std::vector<std::vector<storm::expressions::Expression>> ins(mecStates.size()), outs(mecStates.size());
std::vector<storm::expressions::Expression> choiceVars(transitions.getRowCount()), ecVars(mecStates.size());
std::vector<storm::expressions::Expression> choicesDisjunction;
std::vector<storm::expressions::Expression> leavingSum;
for (auto const& mecState : mecStates) {
std::vector<storm::expressions::Expression> choiceIndicatorVars;
ecVars[mecState] = solver->addLowerBoundedContinuousVariable("e" + std::to_string(mecState), storm::utility::zero<ValueType>()).getExpression();
ins[mecState].push_back(one);
outs[mecState].push_back(ecVars[mecState]);
leavingSum.push_back(ecVars[mecState]);
choiceIndicatorVars.push_back(solver->addBoundedIntegerVariable("c_mec" + std::to_string(mecState), storm::utility::zero<ValueType>(), storm::utility::one<ValueType>()));
solver->addIndicatorConstraint("", choiceIndicatorVars.back().getBaseExpression().asVariableExpression().getVariable(), 0, ecVars[mecState] <= zero);
for (uint64_t choice = transitions.getRowGroupIndices()[mecState]; choice < transitions.getRowGroupIndices()[mecState + 1]; ++choice) {
choiceVars[choice] = solver->addLowerBoundedContinuousVariable("y" + std::to_string(choice), storm::utility::zero<ValueType>()).getExpression();
choiceIndicatorVars.push_back(solver->addBoundedIntegerVariable("c" + std::to_string(choice), storm::utility::zero<ValueType>(), storm::utility::one<ValueType>()).getExpression());
solver->addIndicatorConstraint("", choiceIndicatorVars.back().getBaseExpression().asVariableExpression().getVariable(), 0, choiceVars[choice] <= zero);
choicesDisjunction.push_back(choiceVars[choice]);
outs[mecState].push_back(choiceVars[choice]);
for (auto const& entry : transitions.getRow(choice)) {
if (!storm::utility::isZero(entry.getValue())) {
if (mecStates.get(entry.getColumn())) {
ins[entry.getColumn()].push_back(choiceVars[choice] * solver->getConstant(entry.getValue()));
} else {
leavingSum.push_back(choiceVars[choice] * solver->getConstant(entry.getValue()));
}
}
}
}
//oneOfManyEncoding(choicesSum, *solver);
solver->addConstraint("", storm::expressions::sum(choiceIndicatorVars) == one);
}
for (auto const& mecState : mecStates) {
STORM_LOG_ASSERT(!ins[mecState].empty(), "empty in set at a state");
STORM_LOG_ASSERT(!outs[mecState].empty(), "empty out set at a state");
solver->addConstraint("", storm::expressions::sum(ins[mecState]) == storm::expressions::sum(outs[mecState]));
}
STORM_LOG_ASSERT(!leavingSum.empty(), "empty leaving sum at a mec");
solver->addConstraint("", storm::expressions::sum(leavingSum) == solver->getConstant(storm::utility::convertNumber<ValueType, uint64_t>(mecStates.getNumberOfSetBits())));
choicesDisjunction.push_back(one);
auto boundVar = solver->addUnboundedContinuousVariable("bound", storm::utility::one<ValueType>());
solver->addGeneralConstraint("", boundVar, storm::solver::GurobiLpSolver<ValueType>::GeneralConstraintOperator::Max, choicesDisjunction);
solver->optimize();
STORM_LOG_THROW(!solver->isInfeasible(), storm::exceptions::UnexpectedException, "MEC LP has infeasable solution");
STORM_LOG_THROW(!solver->isUnbounded(), storm::exceptions::UnexpectedException, "MEC LP has unbounded solution");
return solver->getObjectiveValue();
}
*/
template <typename ModelType> template <typename ModelType>
std::vector<typename ModelType::ValueType> DeterministicSchedsObjectiveHelper<ModelType>::computeUpperBoundOnExpectedVisitingTimes(storm::storage::SparseMatrix<ValueType> const& modelTransitions, storm::storage::BitVector const& bottomStates, storm::storage::BitVector const& nonBottomStates, bool hasEndComponents) { std::vector<typename ModelType::ValueType> DeterministicSchedsObjectiveHelper<ModelType>::computeUpperBoundOnExpectedVisitingTimes(storm::storage::SparseMatrix<ValueType> const& modelTransitions, storm::storage::BitVector const& bottomStates, storm::storage::BitVector const& nonBottomStates, bool hasEndComponents) {
storm::storage::SparseMatrix<ValueType> transitions; storm::storage::SparseMatrix<ValueType> transitions;
@ -306,7 +389,19 @@ namespace storm {
// slow down mec states by adding self loop probability 1-lpath // slow down mec states by adding self loop probability 1-lpath
for (auto const& mec : mecs) { for (auto const& mec : mecs) {
ValueType lpath = storm::utility::one<ValueType>(); ValueType lpath = storm::utility::one<ValueType>();
if (true) {
/* //smt/lp
storm::storage::BitVector mecStates(modelTransitions.getRowGroupCount(), false);
uint64_t numTransitions = 0;
uint64_t numChoices = 0;
for (auto const& stateChoices : mec) {
mecStates.set(stateChoices.first);
numTransitions += modelTransitions.getRowGroup(stateChoices.first).getNumberOfEntries();
numChoices += modelTransitions.getRowGroupSize(stateChoices.first);
}
std::cout << "Checking a mec with " << mecStates.getNumberOfSetBits() << " states " << numChoices << " choices and " << numTransitions << " transitions." << std::endl;
lpath = storm::utility::one<ValueType>() / getExpVisitsUpperBoundForMec(mecStates, modelTransitions);
}*/
// Multiply the smallest probability occurring at each state.
for (auto const& stateChoices : mec) { for (auto const& stateChoices : mec) {
auto state = stateChoices.first; auto state = stateChoices.first;
ValueType minProb = storm::utility::one<ValueType>(); ValueType minProb = storm::utility::one<ValueType>();
@ -329,8 +424,36 @@ namespace storm {
} }
lpath *= minProb; lpath *= minProb;
} }
// We multiply the smallest transition probabilities occurring at each state and MEC-Choice
// as well as the smallest 'exit' probability
ValueType minExitProbability = storm::utility::one<ValueType>();
for (auto const& stateChoices : mec) {
auto state = stateChoices.first;
ValueType minProb = storm::utility::one<ValueType>();
for (uint64_t choice = transitions.getRowGroupIndices()[state]; choice < transitions.getRowGroupIndices()[state + 1]; ++state) {
if (stateChoices.second.count(choice) == 0) {
// The choice leaves the EC, so we take the sum over the exiting probabilities
ValueType exitProbabilitySum = storm::utility::zero<ValueType>();
for (auto const& transition : transitions.getRow(choice)) {
if (!mec.containsState(transition.getColumn())) {
exitProbabilitySum += transition.getValue();
}
} }
if (false) {
minExitProbability = std::min(minExitProbability, exitProbabilitySum);
} else {
// Get the minimum over all transition probabilities
for (auto const& transition : transitions.getRow(choice)) {
if (!storm::utility::isZero(transition.getValue())) {
minProb = std::min(minProb, transition.getValue());
}
}
}
}
lpath *= minProb;
}
lpath *= minExitProbability;
/* other ideas...
std::vector<ValueType> leastPathProbs(modelTransitions.getRowGroupCount(), storm::utility::one<ValueType>()); std::vector<ValueType> leastPathProbs(modelTransitions.getRowGroupCount(), storm::utility::one<ValueType>());
std::vector<ValueType> prevLeastPathProbs(modelTransitions.getRowGroupCount(), storm::utility::one<ValueType>()); std::vector<ValueType> prevLeastPathProbs(modelTransitions.getRowGroupCount(), storm::utility::one<ValueType>());
uint64_t mecSize = std::distance(mec.begin(), mec.end()); uint64_t mecSize = std::distance(mec.begin(), mec.end());
@ -370,9 +493,9 @@ namespace storm {
std::cout << "\tnew lpath is " << storm::utility::convertNumber<double>(lpath) << ". checked " << counter << " paths." << std::endl; std::cout << "\tnew lpath is " << storm::utility::convertNumber<double>(lpath) << ". checked " << counter << " paths." << std::endl;
} }
} }
}
}*/
STORM_LOG_ASSERT(!storm::utility::isZero(lpath), "unexpected value of lpath"); STORM_LOG_ASSERT(!storm::utility::isZero(lpath), "unexpected value of lpath");
STORM_LOG_WARN_COND(lpath >= storm::utility::convertNumber<ValueType>(0.01), "Small lower bound for the probability to leave a mec: " << storm::utility::convertNumber<double>(lpath) << ". Numerical issues might occur.");
STORM_LOG_WARN_COND(lpath >= storm::utility::convertNumber<ValueType>(0.001), "Small lower bound for the probability to leave a mec: " << storm::utility::convertNumber<double>(lpath) << ". Numerical issues might occur.");
uint64_t mecState = modelToSubsystemStateMapping.get()[mec.begin()->first]; uint64_t mecState = modelToSubsystemStateMapping.get()[mec.begin()->first];
// scale all the probabilities at this state with lpath // scale all the probabilities at this state with lpath
for (uint64_t mecChoice = transitions.getRowGroupIndices()[mecState]; mecChoice < transitions.getRowGroupIndices()[mecState + 1]; ++mecChoice) { for (uint64_t mecChoice = transitions.getRowGroupIndices()[mecState]; mecChoice < transitions.getRowGroupIndices()[mecState + 1]; ++mecChoice) {

4
src/storm/solver/GurobiLpSolver.cpp
View File

@ -184,7 +184,7 @@ namespace storm {
template<typename ValueType> template<typename ValueType>
void GurobiLpSolver<ValueType>::addConstraint(std::string const& name, storm::expressions::Expression const& constraint) { void GurobiLpSolver<ValueType>::addConstraint(std::string const& name, storm::expressions::Expression const& constraint) {
STORM_LOG_TRACE("Adding constraint " << name << " to GurobiLpSolver:" << std::endl << "\t" << constraint);
STORM_LOG_TRACE("Adding constraint " << (name == "" ? std::to_string(nextConstraintIndex) : name) << " to GurobiLpSolver:" << std::endl << "\t" << constraint);
STORM_LOG_THROW(constraint.isRelationalExpression(), storm::exceptions::InvalidArgumentException, "Illegal constraint is not a relational expression."); STORM_LOG_THROW(constraint.isRelationalExpression(), storm::exceptions::InvalidArgumentException, "Illegal constraint is not a relational expression.");
STORM_LOG_THROW(constraint.getOperator() != storm::expressions::OperatorType::NotEqual, storm::exceptions::InvalidArgumentException, "Illegal constraint uses inequality operator."); STORM_LOG_THROW(constraint.getOperator() != storm::expressions::OperatorType::NotEqual, storm::exceptions::InvalidArgumentException, "Illegal constraint uses inequality operator.");
@ -569,7 +569,7 @@ namespace storm {
if (relative) { if (relative) {
return result; return result;
} else { } else {
return result * getObjectiveValue();
return storm::utility::abs<ValueType>(result * getObjectiveValue());
} }
} }

17
src/storm/storage/geometry/PolytopeTree.h
View File

@ -114,6 +114,23 @@ namespace storm {
return children; return children;
} }
std::string toId() {
if (isEmpty()) {
return "empty";
}
std::stringstream s;
s << "p";
auto vertices = getPolytope()->getVertices();
for (auto const& v : vertices) {
s << "_";
for (auto const& vi : v) {
s << storm::utility::convertNumber<double>(vi) << "-";
}
}
s << "_id" << children.data();
return s.str();
}
/*! /*!
* Returns a string representation of this node (for debugging purposes) * Returns a string representation of this node (for debugging purposes)
*/ */

Write Preview
Loading…
Cancel
Save