Browse Source

Cmake: added a comment that the stack check issue seems to be resolved in more recent clang versions (but still not in the one that comes with the command line tools right now)

tempestpy_adaptions
Tim Quatmann 5 years ago
parent
commit
f1462bfda7
  1. 3
      CMakeLists.txt

3
CMakeLists.txt

@ -196,7 +196,8 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
message(FATAL_ERROR "AppleClang version must be at least 7.3.")
elseif ((CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 11.0) OR (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0))
message(WARNING "Temporarily disabling stack checks for AppleClang 11.0 or higher.")
# TODO: In release mode, stack checks currently fail at runtime. Might be a compiler bug as there does not seem to be faulty behavior.
# TODO: In release mode, stack checks currently fail at runtime. Might be a compiler bug as there does not seem to be faulty behavior.
# TODO: This seems to be fixed for clang 11.0.3 (bundled with XCode 11.5). Check again, if the clang version coming with the command line tools is greater than 11.0.0.
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-stack-check")
endif()

Loading…
Cancel
Save