From f1462bfda7963fcd495621fece1b266aa4a1aeeb Mon Sep 17 00:00:00 2001 From: Tim Quatmann Date: Wed, 10 Jun 2020 15:55:37 +0200 Subject: [PATCH] Cmake: added a comment that the stack check issue seems to be resolved in more recent clang versions (but still not in the one that comes with the command line tools right now) --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4a3294ad4..fba289c3a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -196,7 +196,8 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang") message(FATAL_ERROR "AppleClang version must be at least 7.3.") elseif ((CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 11.0) OR (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.0)) message(WARNING "Temporarily disabling stack checks for AppleClang 11.0 or higher.") - # TODO: In release mode, stack checks currently fail at runtime. Might be a compiler bug as there does not seem to be faulty behavior. + # TODO: In release mode, stack checks currently fail at runtime. Might be a compiler bug as there does not seem to be faulty behavior. + # TODO: This seems to be fixed for clang 11.0.3 (bundled with XCode 11.5). Check again, if the clang version coming with the command line tools is greater than 11.0.0. set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-stack-check") endif()