From 5f6637448130e1274111894c2d3b2bf5ef4dd3e1 Mon Sep 17 00:00:00 2001
From: tomjanson <tom.janson@rwth-aachen.de>
Date: Fri, 12 Feb 2016 23:00:21 +0100
Subject: [PATCH] vector to map conversion

---
 src/utility/shortestPaths.cpp |  4 +++-
 src/utility/shortestPaths.h   | 29 +++++++++++++++++++++++------
 2 files changed, 26 insertions(+), 7 deletions(-)

diff --git a/src/utility/shortestPaths.cpp b/src/utility/shortestPaths.cpp
index ffd3730f1..f70799d15 100644
--- a/src/utility/shortestPaths.cpp
+++ b/src/utility/shortestPaths.cpp
@@ -27,7 +27,9 @@ namespace storm {
                 candidatePaths.resize(numStates);
             }
 
-            // TODO: probTargetVector [!] to probTargetMap ctor
+            template <typename T>
+            ShortestPathsGenerator<T>::ShortestPathsGenerator(storage::SparseMatrix<T> transitionMatrix, std::vector<T> targetProbVector, BitVector initialStates)
+                    : ShortestPathsGenerator<T>(transitionMatrix, vectorToMap(targetProbVector), initialStates) {}
 
             // extracts the relevant info from the model and delegates to ctor above
             template <typename T>
diff --git a/src/utility/shortestPaths.h b/src/utility/shortestPaths.h
index 400485997..b78a0758a 100644
--- a/src/utility/shortestPaths.h
+++ b/src/utility/shortestPaths.h
@@ -65,11 +65,11 @@ namespace storm {
                 ShortestPathsGenerator(std::shared_ptr<models::sparse::Model<T>> model, std::string const& targetLabel = "target");
 
                 // a further alternative: use transition matrix of maybe-states
-                // combined with target vector (e.g., the instantiated matrix/
-                // vector from SamplingModel);
+                // combined with target vector (e.g., the instantiated matrix/vector from SamplingModel);
                 // in this case separately specifying a target makes no sense
-                //ShortestPathsGenerator(storm::storage::SparseMatrix<T> maybeTransitionMatrix, std::vector<T> targetProbVector);
-                ShortestPathsGenerator(storm::storage::SparseMatrix<T> maybeTransitionMatrix, std::unordered_map<state_t, T> targetProbMap, BitVector initialStates);
+                ShortestPathsGenerator(storage::SparseMatrix<T> transitionMatrix, std::vector<T> targetProbVector, BitVector initialStates);
+                ShortestPathsGenerator(storage::SparseMatrix<T> maybeTransitionMatrix, std::unordered_map<state_t, T> targetProbMap, BitVector initialStates);
+
 
                 inline ~ShortestPathsGenerator(){}
 
@@ -174,13 +174,30 @@ namespace storm {
                 /**
                  * Returns a map where each state of the input BitVector is mapped to 1 (`one<T>`).
                  */
-                inline std::unordered_map<state_t, T> allProbOneMap(BitVector bitVector) const& {
+                inline std::unordered_map<state_t, T> allProbOneMap(BitVector bitVector) const {
                     std::unordered_map<state_t, T> stateProbMap;
                     for (state_t node : bitVector) {
-                        stateProbMap.emplace(node, one<T>());
+                        stateProbMap.emplace(node, one<T>()); // FIXME check rvalue warning (here and below)
                     }
                     return stateProbMap;
                 }
+
+                inline std::unordered_map<state_t, T> vectorToMap(std::vector<T> probVector) const {
+                    assert(probVector.size() == numStates);
+
+                    std::unordered_map<state_t, T> stateProbMap;
+
+                    // non-zero entries (i.e. true transitions) are added to the map
+                    for (state_t i = 0; i < probVector.size(); i++) {
+                        T probEntry = probVector[i];
+                        if (probEntry != 0) {
+                            assert(0 < probEntry <= 1);
+                            stateProbMap.emplace(i, probEntry);
+                        }
+                    }
+
+                    return stateProbMap;
+                }
                 // -----------------------
             };
         }