Browse Source

fixing settings/tests

main
dehnert 7 years ago
parent
commit
5706831ad6
  1. 4
      src/storm/settings/modules/AbstractionSettings.cpp
  2. 7
      src/storm/settings/modules/AbstractionSettings.h
  3. 104
      src/test/storm/abstraction/PrismMenuGameTest.cpp

4
src/storm/settings/modules/AbstractionSettings.cpp

@ -180,6 +180,10 @@ namespace storm {
this->getOption(addAllGuardsOptionName).getArgumentByName("value").setFromStringValue(value ? "on" : "off");
}
void AbstractionSettings::setAddAllInitialExpressions(bool value) {
this->getOption(addInitialExpressionsOptionName).getArgumentByName("value").setFromStringValue(value ? "on" : "off");
}
bool AbstractionSettings::isUseInterpolationSet() const {
return this->getOption(useInterpolationOptionName).getArgumentByName("value").getValueAsString() == "on";
}

7
src/storm/settings/modules/AbstractionSettings.h

@ -76,6 +76,13 @@ namespace storm {
*/
void setAddAllGuards(bool value);
/*!
* Sets the option to add all initial expressions to the specified value.
*
* @param value The new value.
*/
void setAddAllInitialExpressions(bool value);
/*!
* Retrieves whether the option to use interpolation was set.
*

104
src/test/storm/abstraction/PrismMenuGameTest.cpp

@ -23,7 +23,9 @@
#include "storm/settings/modules/AbstractionSettings.h"
TEST(PrismMenuGame, DieAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -47,7 +49,9 @@ TEST(PrismMenuGame, DieAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, DieAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -97,7 +101,9 @@ TEST(PrismMenuGame, DieAbstractionTest_Sylvan) {
#endif
TEST(PrismMenuGame, DieAbstractionAndRefinementTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -124,7 +130,9 @@ TEST(PrismMenuGame, DieAbstractionAndRefinementTest_Cudd) {
}
TEST(PrismMenuGame, DieAbstractionAndRefinementTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -151,7 +159,9 @@ TEST(PrismMenuGame, DieAbstractionAndRefinementTest_Sylvan) {
}
TEST(PrismMenuGame, DieFullAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -191,7 +201,9 @@ TEST(PrismMenuGame, DieFullAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, DieFullAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/die.pm");
@ -231,7 +243,9 @@ TEST(PrismMenuGame, DieFullAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, CrowdsAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -257,7 +271,9 @@ TEST(PrismMenuGame, CrowdsAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, CrowdsAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -283,7 +299,9 @@ TEST(PrismMenuGame, CrowdsAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, CrowdsAbstractionAndRefinementTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -311,7 +329,9 @@ TEST(PrismMenuGame, CrowdsAbstractionAndRefinementTest_Cudd) {
}
TEST(PrismMenuGame, CrowdsAbstractionAndRefinementTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -339,7 +359,9 @@ TEST(PrismMenuGame, CrowdsAbstractionAndRefinementTest_Sylvan) {
}
TEST(PrismMenuGame, CrowdsFullAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -419,7 +441,9 @@ TEST(PrismMenuGame, CrowdsFullAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, CrowdsFullAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/dtmc/crowds-5-5.pm");
program = program.substituteConstants();
@ -499,7 +523,9 @@ TEST(PrismMenuGame, CrowdsFullAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, TwoDiceAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -527,7 +553,9 @@ TEST(PrismMenuGame, TwoDiceAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, TwoDiceAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -555,7 +583,9 @@ TEST(PrismMenuGame, TwoDiceAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, TwoDiceAbstractionAndRefinementTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -585,7 +615,9 @@ TEST(PrismMenuGame, TwoDiceAbstractionAndRefinementTest_Cudd) {
}
TEST(PrismMenuGame, TwoDiceAbstractionAndRefinementTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -615,7 +647,9 @@ TEST(PrismMenuGame, TwoDiceAbstractionAndRefinementTest_Sylvan) {
}
TEST(PrismMenuGame, TwoDiceFullAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -674,7 +708,9 @@ TEST(PrismMenuGame, TwoDiceFullAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, TwoDiceFullAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/two_dice.nm");
program = program.substituteConstants();
@ -733,7 +769,9 @@ TEST(PrismMenuGame, TwoDiceFullAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, WlanAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();
@ -754,7 +792,7 @@ TEST(PrismMenuGame, WlanAbstractionTest_Cudd) {
storm::abstraction::MenuGame<storm::dd::DdType::CUDD, double> game = abstractor.abstract();
EXPECT_EQ(915ull, game.getNumberOfTransitions());
EXPECT_EQ(903ull, game.getNumberOfTransitions());
EXPECT_EQ(8ull, game.getNumberOfStates());
EXPECT_EQ(4ull, game.getBottomStates().getNonZeroCount());
@ -762,7 +800,9 @@ TEST(PrismMenuGame, WlanAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, WlanAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();
@ -783,7 +823,7 @@ TEST(PrismMenuGame, WlanAbstractionTest_Sylvan) {
storm::abstraction::MenuGame<storm::dd::DdType::Sylvan, double> game = abstractor.abstract();
EXPECT_EQ(915ull, game.getNumberOfTransitions());
EXPECT_EQ(903ull, game.getNumberOfTransitions());
EXPECT_EQ(8ull, game.getNumberOfStates());
EXPECT_EQ(4ull, game.getBottomStates().getNonZeroCount());
@ -791,7 +831,9 @@ TEST(PrismMenuGame, WlanAbstractionTest_Sylvan) {
}
TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();
@ -814,7 +856,7 @@ TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Cudd) {
storm::abstraction::MenuGame<storm::dd::DdType::CUDD, double> game = abstractor.abstract();
EXPECT_EQ(1824ull, game.getNumberOfTransitions());
EXPECT_EQ(1800ull, game.getNumberOfTransitions());
EXPECT_EQ(16ull, game.getNumberOfStates());
EXPECT_EQ(8ull, game.getBottomStates().getNonZeroCount());
@ -822,7 +864,9 @@ TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Cudd) {
}
TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();
@ -845,7 +889,7 @@ TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Sylvan) {
storm::abstraction::MenuGame<storm::dd::DdType::Sylvan, double> game = abstractor.abstract();
EXPECT_EQ(1824ull, game.getNumberOfTransitions());
EXPECT_EQ(1800ull, game.getNumberOfTransitions());
EXPECT_EQ(16ull, game.getNumberOfStates());
EXPECT_EQ(8ull, game.getBottomStates().getNonZeroCount());
@ -853,7 +897,9 @@ TEST(PrismMenuGame, WlanAbstractionAndRefinementTest_Sylvan) {
}
TEST(PrismMenuGame, WlanFullAbstractionTest_Cudd) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();
@ -980,7 +1026,9 @@ TEST(PrismMenuGame, WlanFullAbstractionTest_Cudd) {
}
TEST(PrismMenuGame, WlanFullAbstractionTest_Sylvan) {
storm::settings::mutableAbstractionSettings().setAddAllGuards(false);
auto& settings = storm::settings::mutableAbstractionSettings();
settings.setAddAllGuards(false);
settings.setAddAllInitialExpressions(false);
storm::prism::Program program = storm::parser::PrismParser::parse(STORM_TEST_RESOURCES_DIR "/mdp/wlan0-2-4.nm");
program = program.substituteConstants();

Loading…
Cancel
Save