Browse Source

Updated TODOs

Former-commit-id: aa509875cd
tempestpy_adaptions
mdeutschen 8 years ago
committed by Sebastian Junges
parent
commit
3072f142b5
  1. 20
      src/transformations/dft/DftToGspnTransformator.cpp
  2. 2
      src/transformations/dft/DftToGspnTransformator.h

20
src/transformations/dft/DftToGspnTransformator.cpp

@ -16,8 +16,6 @@ namespace storm {
mGspn = storm::gspn::GSPN(); mGspn = storm::gspn::GSPN();
mGspn.setName("DftToGspnTransformation"); mGspn.setName("DftToGspnTransformation");
// TODO: Reconsider priorities!
// Loop through every DFT element and draw them as a GSPN. // Loop through every DFT element and draw them as a GSPN.
drawGSPNElements(); drawGSPNElements();
@ -77,7 +75,6 @@ namespace storm {
break; break;
case storm::storage::DFTElementType::PDEP: case storm::storage::DFTElementType::PDEP:
drawPDEP(std::static_pointer_cast<storm::storage::DFTDependency<ValueType> const>(dftElement)); drawPDEP(std::static_pointer_cast<storm::storage::DFTDependency<ValueType> const>(dftElement));
//STORM_LOG_THROW(false, storm::exceptions::NotImplementedException, "The transformation of a PDEP is not yet implemented.");
break; break;
default: default:
STORM_LOG_ASSERT(false, "DFT type unknown."); STORM_LOG_ASSERT(false, "DFT type unknown.");
@ -403,22 +400,22 @@ namespace storm {
} }
case storm::storage::DFTElementType::MUTEX: case storm::storage::DFTElementType::MUTEX:
{ {
// MUTEX is not implemented yet. Nothing to do here.
// MUTEX are realized with restrictions. Nothing to do here.
break; break;
} }
case storm::storage::DFTElementType::BE: case storm::storage::DFTElementType::BE:
{ {
// The parent is never a Basic Event (Except for SPAREs?).
// The parent is never a Basic Event.
break; break;
} }
case storm::storage::DFTElementType::CONSTF: case storm::storage::DFTElementType::CONSTF:
{ {
// The parent is never a Basic Event (Except for SPAREs?).
// The parent is never a Basic Event.
break; break;
} }
case storm::storage::DFTElementType::CONSTS: case storm::storage::DFTElementType::CONSTS:
{ {
// The parent is never a Basic Event (Except for SPAREs?).
// The parent is never a Basic Event.
break; break;
} }
case storm::storage::DFTElementType::PDEP: case storm::storage::DFTElementType::PDEP:
@ -525,7 +522,6 @@ namespace storm {
} }
} }
} }
// TODO: Does the DEP has a parent?
} }
template <typename ValueType> template <typename ValueType>
@ -570,10 +566,14 @@ namespace storm {
} }
break; break;
} }
case storm::storage::DFTElementType::MUTEX:
{
// MUTEX is not implemented by the DFTGalileoParser yet. Nothing to do here.
STORM_LOG_ASSERT(false, "MUTEX is not supported by DftToGspnTransformator.");
break;
}
default: default:
{ {
// TODO: Are there other restrictions than SEQ?
// TODO: There is: MUTEX.
break; break;
} }
} }

2
src/transformations/dft/DftToGspnTransformator.h

@ -63,7 +63,7 @@ namespace storm {
void drawGSPNDependencies(); void drawGSPNDependencies();
/* /*
* Draw restrictions between the elements of the GSPN (i.e. SEQ).
* Draw restrictions between the elements of the GSPN (i.e. SEQ or MUTEX).
*/ */
void drawGSPNRestrictions(); void drawGSPNRestrictions();

Loading…
Cancel
Save