From 9b24da5a3870b2c4784c1b48c906844dbc9d9e50 Mon Sep 17 00:00:00 2001 From: Alexei Sheplyakov Date: Thu, 21 Aug 2008 16:06:02 +0400 Subject: [PATCH] Get rid CL_REQUIRE/CL_PROVIDE(cl_F_mostneg), it is not really necessary. Move static variables most_negative_[SFDL]F into most_negative_LF() function (which is the only user of those variables) in order to avoid possible static order initialization problems. While at it, make most_negative_LF() function static. --- include/cln/float.h | 1 - src/float/misc/cl_F_mostneg.cc | 35 ++++++++++++++++------------------ 2 files changed, 16 insertions(+), 20 deletions(-) diff --git a/include/cln/float.h b/include/cln/float.h index 6a3f9bf..ada8a29 100644 --- a/include/cln/float.h +++ b/include/cln/float.h @@ -559,7 +559,6 @@ extern const cl_F most_positive_float (float_format_t f); // Returns the smallest (most negative) floating point number in float format f. extern const cl_F most_negative_float (float_format_t f); -//CL_REQUIRE(cl_F_mostneg) // Returns the least positive floating point number (i.e. > 0 but closest to 0) // in float format f. diff --git a/src/float/misc/cl_F_mostneg.cc b/src/float/misc/cl_F_mostneg.cc index 1008f83..c393fa6 100644 --- a/src/float/misc/cl_F_mostneg.cc +++ b/src/float/misc/cl_F_mostneg.cc @@ -3,8 +3,6 @@ // General includes. #include "cl_sysdep.h" -CL_PROVIDE(cl_F_mostneg) - // Specification. #include "cln/float.h" @@ -19,22 +17,7 @@ CL_PROVIDE(cl_F_mostneg) namespace cln { -// Exponent so groß wie möglich, Mantisse 1...1, Vorzeichen -. - -static const cl_SF most_negative_SF = - make_SF(-1,SF_exp_high,bit(SF_mant_len+1)-1); - -static const cl_FF most_negative_FF = - encode_FF(-1,FF_exp_high-FF_exp_mid,bit(FF_mant_len+1)-1); - -static const cl_DF most_negative_DF = -#if (cl_word_size==64) - encode_DF(-1,DF_exp_high-DF_exp_mid,bit(DF_mant_len+1)-1); -#else - encode_DF(-1,DF_exp_high-DF_exp_mid,bit(DF_mant_len-32+1)-1,bitm(32)-1); -#endif - -inline const cl_LF most_negative_LF (uintC len) +static inline const cl_LF most_negative_LF (uintC len) { var Lfloat erg = allocate_lfloat(len,LF_exp_high,-1); fill_loop_up(&TheLfloat(erg)->data[0],len,~(uintD)0); @@ -43,6 +26,21 @@ inline const cl_LF most_negative_LF (uintC len) const cl_F most_negative_float (float_format_t f) { + // Exponent so groß wie möglich, Mantisse 1...1, Vorzeichen -. + + static const cl_SF most_negative_SF = + make_SF(-1,SF_exp_high,bit(SF_mant_len+1)-1); + + static const cl_FF most_negative_FF = + encode_FF(-1,FF_exp_high-FF_exp_mid,bit(FF_mant_len+1)-1); + + static const cl_DF most_negative_DF = +#if (cl_word_size==64) + encode_DF(-1,DF_exp_high-DF_exp_mid,bit(DF_mant_len+1)-1); +#else + encode_DF(-1,DF_exp_high-DF_exp_mid,bit(DF_mant_len-32+1)-1,bitm(32)-1); +#endif + floatformatcase((uintC)f , return most_negative_SF; , return most_negative_FF; @@ -53,4 +51,3 @@ const cl_F most_negative_float (float_format_t f) } // namespace cln -CL_PROVIDE_END(cl_F_mostneg)